[FFmpeg-devel] [PATCH] avfilter: add colorvd video filter

Anton Khirnov anton at khirnov.net
Fri Nov 19 16:25:11 EET 2021


Quoting Paul B Mahol (2021-11-19 15:07:13)
> On Fri, Nov 19, 2021 at 3:04 PM Anton Khirnov <anton at khirnov.net> wrote:
> 
> > Quoting Paul B Mahol (2021-11-19 14:55:42)
> > > On Fri, Nov 19, 2021 at 2:27 PM Michael Niedermayer <
> > michael at niedermayer.cc>
> > > wrote:
> > >
> > > > On Fri, Nov 19, 2021 at 02:18:27PM +0100, Anton Khirnov wrote:
> > > > > Quoting James Almer (2021-11-13 13:22:12)
> > > > > > Also, missing docs.
> > > > >
> > > > > Could we add a development rule that all new filters need docs and
> > all
> > > > > new filters/codecs/(de)muxers need a test (unless special
> > circumstances,
> > > > > like hwaccel)?
> > > >
> > > > Iam in favor of this
> > > >
> > > >
> > > Against this, as experimental filters does not need docs,
> >
> > I strongly disagree, even experimental code needs docs. I often find it
> > good idea to write documentation _before_ writing the code.
> >
> > Besides, experimental filters do not belong in the main repository. Keep
> > them in your tree until stop being experimental.
> >
> 
> 
> Never, I will keep posting filters without docs on devel mailing list as I
> wish.

Any such patches are rejected.

I really wish you stopped with these kinds of tantrums, they accomplish
nothing useful, waste everyone's time and make the project look bad.


> 
> 
> >
> > > floats too.
> >
> > This is an excuse, we have ways of dealing with floats.
> >
> 
> Citations needed.

tests/tiny_psnr.c for example. As I'm sure you know very well.

-- 
Anton Khirnov


More information about the ffmpeg-devel mailing list