[FFmpeg-devel] [PATCH V2 1/5] hwcontext_vaapi: Use PRIME_2 memory type for modifiers.

Chen, Wenbin wenbin.chen at intel.com
Thu Nov 25 04:37:01 EET 2021


> 24 Nov 2021, 06:28 by wenbin.chen at intel.com:
> 
> > From: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
> >
> > This way we can pass explicit modifiers in. Sometimes the
> > modifier matters for the number of memory planes that
> > libva accepts, in particular when dealing with
> > driver-compressed textures. Furthermore the driver might
> > not actually be able to determine the implicit modifier
> > if all the buffer-passing has used explicit modifier.
> > All these issues should be resolved by passing in the
> > modifier, and for that we switch to using the PRIME_2
> > memory type.
> >
> > Tested with experimental radeonsi patches for modifiers
> > and kmsgrab. Also tested with radeonsi without the
> > patches to double-check it works without PRIME_2 support.
> >
> > v2:
> >  Cache PRIME_2 support to avoid doing two calls every time on
> >  libva drivers that do not support it.
> >
> > v3:
> >  Remove prime2_vas usage.
> >
> 
> I've pinged jkqxz, the maintainer, but to me it looks good,
> and considering how long this has been on the ML, I'll
> apply it alongside the Vulkan patches if he doesn't respond.
> By the way, it mentions the author is Bas Nieuwenhuizen,
> should I change the commit author when I apply?

Please change commit author to Bas Nieuwenhuizen.
Thanks.

> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list