[FFmpeg-devel] [PATCH] avformat/http: prevent truncation of sanitized_path

[Anton Khirnov]

Quoting James Almer (2021-06-09 22:01:02)
> path1 and sanitized_path are both MAX_URL_SIZE bytes long, yet the latter is
> copied from the former with the addition of one extra character.
> 
> Should fix a -Wformat-truncation warning.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
>  libavformat/http.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 1fc95c768c..1e7d97a027 100644
> --- a/libavformat/http.c
> +++ b/libavformat/http.c
> @@ -192,7 +192,7 @@ static int http_open_cnx_internal(URLContext *h, AVDictionary **options)
>      char *hashmark;
>      char hostname[1024], hoststr[1024], proto[10];
>      char auth[1024], proxyauth[1024] = "";
> -    char path1[MAX_URL_SIZE], sanitized_path[MAX_URL_SIZE];
> +    char path1[MAX_URL_SIZE], sanitized_path[MAX_URL_SIZE + 1];

Looks ok, was about to write the same patch.

-- 
Anton Khirnov