[FFmpeg-devel] [PATCH v16 06/16] avfilter/sbuffer: Add sbuffersrc and sbuffersink filters

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Andreas
> Rheinhardt
> Sent: Friday, November 26, 2021 12:14 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v16 06/16] avfilter/sbuffer: Add
> sbuffersrc and sbuffersink filters
> 
> > +#include "libavcodec/avcodec.h"
> > +
> >  #define FF_INTERNAL_FIELDS 1
> >  #include "framequeue.h"
> >
> > @@ -57,6 +59,10 @@ typedef struct BufferSinkContext {
> >      int *sample_rates;                      ///< list of accepted sample
> rates, terminated by -1
> >      int sample_rates_size;
> >
> > +    /* only used for subtitles */
> > +    enum AVSubtitleType *subtitle_types;     ///< list of accepted
> subtitle types, must be terminated with -1
> 
> subtitle_types is not terminated by -1 at all; it uses the size field
> below instead of a sentinel. The same is true for the other arrays.

My patch does things just analog to the video and audio implementation.
I have no idea in which direction this is intended to go and I think it
is outside the scope of this patch to make any assumptions about
it. Even when it would be clear in which way this should be changed in the 
future - I don't think such change should be part of this patch. 
Also whatever I'd do, I'm sure it would take multiple additional patch 
revisions until everybody is satisfied.
This can be changed later (consistently for all three media types at once),
or - if you see some urgency in this - please change it in the main tree, 
then I'll adapt my patch. 

All other suggestions done.

Thanks,
sw