[FFmpeg-devel] [PATCH 7/8] avfilter/vf_thumbnail_cuda: Fix segfaults on uninit

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Tue Oct 5 23:53:47 EEST 2021


Uninit crashed if an array containing frames could not be allocated
or config_props() has never been called.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
 libavfilter/vf_thumbnail_cuda.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavfilter/vf_thumbnail_cuda.c b/libavfilter/vf_thumbnail_cuda.c
index 491542c60a..7c86203227 100644
--- a/libavfilter/vf_thumbnail_cuda.c
+++ b/libavfilter/vf_thumbnail_cuda.c
@@ -306,6 +306,8 @@ static av_cold void uninit(AVFilterContext *ctx)
 {
     int i;
     ThumbnailCudaContext *s = ctx->priv;
+
+    if (s->hwctx) {
     CudaFunctions *cu = s->hwctx->internal->cuda_dl;
 
     if (s->data) {
@@ -317,10 +319,13 @@ static av_cold void uninit(AVFilterContext *ctx)
         CHECK_CU(cu->cuModuleUnload(s->cu_module));
         s->cu_module = NULL;
     }
+    }
 
+    if (s->frames) {
     for (i = 0; i < s->n_frames && s->frames[i].buf; i++)
         av_frame_free(&s->frames[i].buf);
     av_freep(&s->frames);
+    }
 }
 
 static int request_frame(AVFilterLink *link)
-- 
2.30.2



More information about the ffmpeg-devel mailing list