[FFmpeg-devel] [PATCH] configure: export pkg-config includedir variable

[James Almer]

On 10/8/2021 11:57 AM, Timo Rothenpieler wrote:
> On 08.10.2021 15:32, James Almer wrote:
>> Some packages may not define custom cflags, in which case a simple
>> "pkg-config --cflags" call will return an empty string.
>> This change will be useful to get a valid include path that can be
>> used in library checks.
> 
> Is that at all a standard thing with pkgconfig?
>  From how I understand it, a .pc file could also call that variable 
> incdir, or whatever it likes?

I don't think incdir is a variable used in pc files. All the ones I've 
seen use includedir, and that's what our helpers are already looking 
for, too.

> Never seen that done before anywhere.

See test_pkg_config_cpp()

This is to workaround the issue mentioned in 
https://ffmpeg.org/pipermail/ffmpeg-devel/2021-September/286266.html

This value is already fetched by some of the configure helpers like i 
said above, so I'm just exporting it as a per-library variable, 
preventing the need to do custom calls to pkg-config like that patch 
intends to.

> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>