[FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Add AVFILTER_FLAG_SUPPORT_COMMANDS

[Nicolas George]

Andreas Rheinhardt (12021-10-09):
> Currently an API user has no easy way that always works to know
> whether an AVFilter supports commands. One can check for whether
> the filter has any AVOption with AV_OPT_FLAG_RUNTIME_PARAM set,
> but this is a bit of extra work and more importantly it doesn't
> work for all filters: anequalizer, ladspa, drawtext, overlay, pp,
> concat and (a)movie accept commands, but have no AVOptions of this
> type. Tellingly ffprobe/cmdutils.c has to abuse the API and check
> for AVFilter.process_command to know whether a filter accepts commands.
> 
> This commit fixes this by adding a new AVFilter flag.

I do not like it: it requires redundant changes in all the filters.

It would be more elegant to add avfilter_can_process_commands() that can
check for the process_command callback.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20211009/4b07b946/attachment.sig>