[FFmpeg-devel] [PATCH 1/1] mov: read track title
Dong Nguyen
nguyenduydong at gmail.com
Mon Oct 11 06:23:08 EEST 2021
this change fix issue [9438](https://trac.ffmpeg.org/ticket/9438)
after commit da9cc22d5bd5f59756c2037b02966376da2cf323
ffmpeg is able to write track title metadata to mov/mp4 format file
but it is not able to read back the metadata
Signed-off-by: Dong Nguyen <nguyenduydong at gmail.com>
---
libavformat/mov.c | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index a811bc7677..644e746d02 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -303,6 +303,7 @@ static int mov_read_udta_string(MOVContext *c, AVIOContext *pb, MOVAtom atom)
int (*parse)(MOVContext*, AVIOContext*, unsigned, const char*) = NULL;
int raw = 0;
int num = 0;
+ int track_title = 0;
switch (atom.type) {
case MKTAG( '@','P','R','M'): key = "premiere_version"; raw = 1; break;
@@ -380,6 +381,12 @@ static int mov_read_udta_string(MOVContext *c, AVIOContext *pb, MOVAtom atom)
case MKTAG(0xa9,'l','y','r'): key = "lyrics"; break;
case MKTAG(0xa9,'m','a','k'): key = "make"; break;
case MKTAG(0xa9,'m','o','d'): key = "model"; break;
+ case MKTAG('n','a','m','e') :
+ if (c->trak_index >= 0) { // meta inside track
+ key = "title";
+ track_title = 1;
+ }
+ break;
case MKTAG(0xa9,'n','a','m'): key = "title"; break;
case MKTAG(0xa9,'o','p','e'): key = "original_artist"; break;
case MKTAG(0xa9,'p','r','d'): key = "producer"; break;
@@ -428,7 +435,7 @@ retry:
return ret;
}
} else return 0;
- } else if (atom.size > 4 && key && !c->itunes_metadata && !raw) {
+ } else if (atom.size > 4 && key && !c->itunes_metadata && !raw && !track_title) {
str_size = avio_rb16(pb); // string length
if (str_size > atom.size) {
raw = 1;
@@ -521,7 +528,11 @@ retry:
str[str_size] = 0;
}
c->fc->event_flags |= AVFMT_EVENT_FLAG_METADATA_UPDATED;
- av_dict_set(&c->fc->metadata, key, str, 0);
+ if (track_title) {
+ av_dict_set(&c->fc->streams[c->trak_index]->metadata, key, str, 0);
+ } else {
+ av_dict_set(&c->fc->metadata, key, str, 0);
+ }
if (*language && strcmp(language, "und")) {
snprintf(key2, sizeof(key2), "%s-%s", key, language);
av_dict_set(&c->fc->metadata, key2, str, 0);
--
2.27.0.rc0
More information about the ffmpeg-devel
mailing list