[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit application when decoding returns AVERROR_EXIT

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> James Almer
> Sent: Tuesday, October 19, 2021 4:39 PM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit
> application when decoding returns AVERROR_EXIT
> 
> On 10/19/2021 2:07 AM, Soft Works wrote:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> >> Gyan Doshi
> >> Sent: Tuesday, October 19, 2021 6:51 AM
> >> To: ffmpeg-devel at ffmpeg.org
> >> Subject: Re: [FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg: exit
> >> application when decoding returns AVERROR_EXIT
> >>
> >>
> >>
> >> On 2021-10-19 10:11 am, Soft Works wrote:
> >>
> >>> Maybe there's a better way than my patch, but what happens is
> >>> a bug IMO, and I wouldn't say that it would be a fix to say that
> >>> a certain option needs to be set by the user to "fix it".
> >>
> >> What's ideally required is for user to designate essential and
> >> non-essential parts of the task. Then some errors can be ignored,
> and
> >> some are fatal.
> >
> > Yes, and we know when this will happen - haha.
> >
> > I guess I'll keep my fix and ffmpeg keeps the bug.
> 
> You could also just call ffmpeg with the -xerror option in this
> scenario
> where cuda is failing. It should abort the process at the exact same
> point your patch tries to.

I try to contribute patches based on experience when working 
with ffmpeg for the benefit of other ffmpeg users.
Though, I have no need for these to get merged as we're always
running ffmppeg builds from a custom fork, besides that it would
be nice to keep the differences at a moderate level.

-xerror is a widely unknown parameter that nobody is using, so it 
doesn't help for dealing with this situation. Also it's not 
a fix for a bug to say that it doesn't occur when a certain parameter
is specified.

This is not the first situation where my fixes for obvious and 
clear bugs are talked away with great effort, but with zero
effort and zero interest to find a solution for the actual 
problems they are meant to address.

I am open to suggestions to fix the issue in a different way.
Otherwise - if you prefer to keep things as they are, we 
get just the result I described above: 

It's fixed for me, but the bugs remain unfixed in ffmpeg.

@Paul: I don't see why this would be bad communication, it's just
a simple factual assessment.

Kind regards,
softworkz