[FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet filter

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Mapul Bhola
> Sent: Tuesday, 31 August 2021 23:39
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v2 7/8] avfilter/sleet: Add sleet
> filter
> 
> August 30, 2021 4:17 AM, "Soft Works" <softworkz at hotmail.com> wrote:
> 
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> > v2 Update:
> >
> > - Implemented Andreas' suggestions
> > - overlay_subs filter:
> > - removed duplicated code
> > - implemented direct (no pre-conversion) blending of graphical
> > subtitle rects
> > - Supported input formats:
> > - all packed RGB formats (with and without alpha)
> > - yuv420p, yuv422p, yuv444p
> >
> > libavfilter/Makefile | 3 +
> > libavfilter/allfilters.c | 1 +
> > libavfilter/sf_sleet.c | 209
> +++++++++++++++++++++++++++++++++++++++

[..]

> Softworkz, I like ya, I like ya patches, and the effort your putting
> into the FFMpeg project, but I just don't think this is necessary.
> Contributes to overhead/maintence for what is essentially a gimmick
> feature.
> 
> Code itself loks good to me

Thanks for the kind words, which are rare here in this little conclave
of (partially) freaky developers who are considering themselves as the 
top of excellence, but haven't been able for years to proceed on some 
rather trivial yet highly important and useful issues and shortcomings 
in the current set of ffmpeg functionality.

As for the "sleet" filter: Yes - it is totally useless for practical
use. I had explained why I added it in the 0/8 message:

> Why leet? Real world use is surely questionable, but it has two advantages 
> that make it a great choice for testing: 
> You can see from almost every single line whether it has been filtered, 
> and the text is still readable which allows to verify that timings are 
> still valid.

Much more useful examples for textsub>>textsub filters would be like:

- Censoring filter
- Translation filter (lingual)
- Include Actor Name filter

Though, I wanted to have something super-simple for demonstration of the
new ability to have textsub>>textsub filters.

Maybe an "sallcaps" filter makes slightly more sense than "sleet"?

softworkz