[FFmpeg-devel] [PATCH] avfilter/avfilter: Fix hardcoded input index

Nicolas George george at nsup.org
Mon Sep 6 09:53:02 EEST 2021


Paul B Mahol (12021-09-06):
> Yes. Because .activate fixes numerous issues.
> I see that only scale2ref is still using old way with multiple inputs. It
> probably should be fixed,
> and after that assert should be added in this file so new filters do not
> expose same limitations and mistakes of the past.

Thank you for explaining this.

A filter with several inputs but no synchronization between them is a
nonsense. If there is no synchronization, it should be two separate
filters.

It is possible to synchronize without activate, it was done before
activate; but it is harder.

Anyway, the code that is changed by this patch is the fall-back code for
filters without a request_frame() callback, and this was only ever
allowed if there is a single input.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210906/458a9893/attachment.sig>


More information about the ffmpeg-devel mailing list