[FFmpeg-devel] [PATCH] lavc/packet: deprecate AVPacket.time_base
Lynne
dev at lynne.ee
Thu Sep 9 16:41:50 EEST 2021
9 Sept 2021, 15:34 by george at nsup.org:
> The contents of AVPacket can only make sense with some extra information.
> In FFmpeg, this information is carried by AVStream. Applications can use
> AVStream or define their own data structure for that. There is no reason
> to carry one of these informations everywhere along with the packet.
>
> Furthermore, since this field is only set by libavformat and never used
> by any part of the code, we have absolutely no test coverage. That means
> it can become out of sync with what it should be and we would not
> notice. As a general principle, having the same redundant information in
> several data structures and expecting it to stay in sync is a bad and
> risky practice.
>
> Signed-off-by: Nicolas George <george at nsup.org>
>
NAK.
Patches that use the field have been posted, but have not been merged yet.
More information about the ffmpeg-devel
mailing list