[FFmpeg-devel] [PATCH 03/14] avformat/mp3dec: Simplify checking for no-metadata

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Thu Sep 9 18:57:36 EEST 2021


Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
---
If it were documented that a non-NULL AVDictionary is always nonempty
this could be simplified. But I don't know whether we want to document
that.

 libavformat/mp3dec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c
index 9205abebc4..72c049edaf 100644
--- a/libavformat/mp3dec.c
+++ b/libavformat/mp3dec.c
@@ -384,7 +384,7 @@ static int mp3_read_header(AVFormatContext *s)
     ffiocontext(s->pb)->maxsize = -1;
     off = avio_tell(s->pb);
 
-    if (!av_dict_get(s->metadata, "", NULL, AV_DICT_IGNORE_SUFFIX))
+    if (!av_dict_count(s->metadata))
         ff_id3v1_read(s);
 
     if (s->pb->seekable & AVIO_SEEKABLE_NORMAL)
-- 
2.30.2



More information about the ffmpeg-devel mailing list