[FFmpeg-devel] [PATCH v4 17/18] docs/filters: Add documentation for all new subtitle filters

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Andreas Rheinhardt
> Sent: Saturday, 11 September 2021 12:20
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v4 17/18] docs/filters: Add
> documentation for all new subtitle filters
> 
> Soft Works:
> > Signed-off-by: softworkz <softworkz at hotmail.com>
> > ---
> >  doc/filters.texi | 263
> +++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 263 insertions(+)
> >
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 9ad6031d23..a7b80acada 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> 
> Documentation for each filter (or new filter option) should also be
> added in the same commit that adds the filter (or new filter option).
> This increases atomicity. (Remember that we might reject some of your
> filters, but not others. In case your patches are already atomic, you
> won't have to rework your patches.)
> 

Sure. Regarding atomicity - how about the newly introduced section 
for subtitle filters in filters.texi:

Should it be in the first filter commit or in a separate preceding
commit that just adds the (empty) section?

sw