[FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Hendrik Leppkes
> Sent: Sunday, 12 September 2021 22:15
> To: FFmpeg development discussions and patches <ffmpeg-
> devel at ffmpeg.org>
> Subject: Re: [FFmpeg-devel] [PATCH v5 00/12] Subtitle Filtering
> 
> On Sun, Sep 12, 2021 at 10:07 PM Soft Works <softworkz at hotmail.com>
> wrote:
> >
> > All-in-all that doesn't seem to be worth all the hazzle. Again,
> > that brings me back to my original approach:
> >
> 
> It is for us, if its not for you, what can we say.
> The only approach to go forwards is to prepare proper, clean and
> fully
> featured integration that results in a clean API once the deprecation
> period is over and the old stuff can get removed. Anything else would
> be a hack and only serve your desired purpose, not the long-term API
> design of FFmpeg, which unfortunately is just not acceptable.
> If you are interested in doing it properly, we will listen and guide,
> but if not... thats the only way its going to get accepted.

There's no need to start talking like Nicolas, it would be nice
when we could talk about the subject itself instead.

Would you mind to elaborate on what is bad about AVSubtitle and 
attaching it to AVFrames?

Also could you please describe a bit more detailed how you would
envision the initial step to look like, based on my v5 patchset?

IIUC, that would be:

- Keep the added subtitle properties in AVFrame
- Also keep AVSubtitle
- Don't modify the subtitle encoders and decoders and keep them
  working with AVSubtitle
- In the internal ffmpeg processing:
  - without filtering, just forward AVSubtitle from the decoder
    to the encoder
  - with filtering: Copy AVSubtitle properties to AVFrame for
    filtergraph input, copy back to AVSubtitle at graph output
    for feeding into encoders

So yes, please guide me in terms of what you're expecting, that
will be more productive than letting me guess :-)

Thanks,
softworkz