[FFmpeg-devel] [PATCH 04/10] fftools/cmdutils: Don't report AV_CODEC_CAP_TRUNCATED after next bump

James Almer jamrial at gmail.com
Mon Sep 13 17:08:38 EEST 2021


On 9/13/2021 10:53 AM, Andreas Rheinhardt wrote:
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> Could also be removed now.
> 
>   fftools/cmdutils.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
> index ac172dbd65..6a61f7a5e4 100644
> --- a/fftools/cmdutils.c
> +++ b/fftools/cmdutils.c
> @@ -1399,8 +1399,10 @@ static void print_codec(const AVCodec *c)
>           printf("horizband ");
>       if (c->capabilities & AV_CODEC_CAP_DR1)
>           printf("dr1 ");
> +#if LIBAVCODEC_VERSION_MAJOR < 60

If for whatever reason the capability deprecation is postponed, this 
check will no longer be valid.

Since FF_API_* defines should not be used outside their libraries, i 
think it'd be better to just remove this now like you suggested above.

>       if (c->capabilities & AV_CODEC_CAP_TRUNCATED)
>           printf("trunc ");
> +#endif
>       if (c->capabilities & AV_CODEC_CAP_DELAY)
>           printf("delay ");
>       if (c->capabilities & AV_CODEC_CAP_SMALL_LAST_FRAME)
> 



More information about the ffmpeg-devel mailing list