[FFmpeg-devel] [PATCH v2 13/14] avfilter/avfilter: Don't fail upon options for filter without AVClass

[Nicolas George]

Andreas Rheinhardt (12021-09-14):
> Commit 62549f9655c48f0ec061087fa33a96040ce01145 added a check to
> (the predecessor of) avfilter_init_str() to error out if options
> were provided to a filter without options (or rather, without private
> class). This was fine at the time, yet soon afterwards commit
> fdd93eabfb2644f541f7aac9943abce26776ea73 added a generic option
> for all AVFilterContexts and since then it is wrong to error out
> in case options have been provided to a filter without AVClass.
> 
> To workaround this issue, several filters with timeline support
> added AVClasses and empty options; these will be removed in subsequent
> commits. Furthermore, the super2xsai filter supports slice threading,
> but no options and so has no AVClass, making it impossible to set
> the number of threads when using avfilter_init_str() (and therefore
> from the ffmpeg-tool). This is fixed by this commit, too.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
> ---
> Now with a comment explaining the two functions of checking for priv.
> 
>  libavfilter/avfilter.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)

Ok, I suppose.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210916/1bc80e5f/attachment.sig>