[FFmpeg-devel] [PATCH 4/4] avcodec/siren: Check index for catergory5

Michael Niedermayer michael at niedermayer.cc
Fri Sep 17 22:56:16 EEST 2021


Fixes: out of array access
Fixes: 38603/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSNSIREN_fuzzer-5741847809490944.fuzz

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavcodec/siren.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/siren.c b/libavcodec/siren.c
index 2161b29a2cc..7f2b4678608 100644
--- a/libavcodec/siren.c
+++ b/libavcodec/siren.c
@@ -648,6 +648,10 @@ static int decode_vector(SirenContext *s, int number_of_regions,
                 }
                 coefs_ptr++;
             }
+            if (i >= FF_ARRAY_ELEMS(noise_category5)) {
+                error = 1;
+                break;
+            }
 
             noise = decoder_standard_deviation[region] * noise_category5[i];
         } else
-- 
2.17.1



More information about the ffmpeg-devel mailing list