[FFmpeg-devel] [PATCH 2/2] swscale: add input/output support for X2BGR10LE

Manuel Stoeckl code at mstoeckl.com
Mon Sep 20 05:28:37 EEST 2021


> 
> have you confirmed that all the added codepathes produce correct
> looking output ?
> 

I've attached a test program which should cover all the modified code
paths. The new X2BGR10 code works just as well as the X2RGB10 code, but:

* converting FROM X2RGB10LE or X2BGR10LE works
* converting TO X2RGB10LE or X2BGR10LE dims all pixels by a factor of 4.
  Also, a 'full chroma interpolation [...] not yet implemented' warning 
  is printed.

The factor 4 dimming can be fixed by increasing rbase/gbase/bbase
shifts by 2 in libswscale, yuv2rgb.c, ff_yuv2rgb_c_init_tables, case 30.

So, unless otherwise recommended:
* I will send a separate patch fixing the shift values and updating
  x2rgb10le FATE test results
* Patch 2/2 will be updated to apply after this patch
* Patch 1/2 of this series will be unaffected
-------------- next part --------------
A non-text attachment was scrubbed...
Name: roundtrip.c
Type: text/x-c++src
Size: 5509 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210919/f0ffed93/attachment.c>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20210919/f0ffed93/attachment.sig>


More information about the ffmpeg-devel mailing list