[FFmpeg-devel] [PATCH 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

[quietvoid]

On 22/09/2021 20.55, Andreas Rheinhardt wrote:
> quietvoid:
>> Most of the implementation was done by the Plex developers.
>>
>> Signed-off-by: quietvoid <tcChlisop0 at gmail.com>
>> ---
>>   libavformat/matroska.h    |  7 ++++++
>>   libavformat/matroskadec.c | 45 +++++++++++++++++++++++++++++++++++++--
>>   2 files changed, 50 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavformat/matroska.h b/libavformat/matroska.h
>> index 2d04a6838b..4b2a3310a4 100644
>> --- a/libavformat/matroska.h
>> +++ b/libavformat/matroska.h
>> @@ -111,6 +111,7 @@
>>   #define MATROSKA_ID_TRACKCONTENTENCODING 0x6240
>>   #define MATROSKA_ID_TRACKTIMECODESCALE 0x23314F
>>   #define MATROSKA_ID_TRACKMAXBLKADDID 0x55EE
>> +#define MATROSKA_ID_TRACKBLKADDMAPPING 0x41E4
>>     /* IDs in the trackvideo master */
>>   #define MATROSKA_ID_VIDEOFRAMERATE 0x2383E3
>> @@ -189,6 +190,12 @@
>>   #define MATROSKA_ID_ENCODINGSIGKEYID 0x47E4
>>   #define MATROSKA_ID_ENCODINGSIGNATURE 0x47E3
>>   +/* IDs in the block addition mapping master */
>> +#define MATROSKA_ID_BLKADDIDVALUE 0x41F0
>> +#define MATROSKA_ID_BLKADDIDNAME 0x41A4
>> +#define MATROSKA_ID_BLKADDIDTYPE 0x41E7
>> +#define MATROSKA_ID_BLKADDIDEXTRADATA 0x41ED
>> +
>>   /* ID in the cues master */
>>   #define MATROSKA_ID_POINTENTRY 0xBB
>>   diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
>> index 500c83ac3a..8ae553953d 100644
>> --- a/libavformat/matroskadec.c
>> +++ b/libavformat/matroskadec.c
>> @@ -239,6 +239,13 @@ typedef struct MatroskaTrackOperation {
>>       EbmlList combine_planes;
>>   } MatroskaTrackOperation;
>>   +typedef struct MatroskaBlockAdditionMapping {
>> +    int value;
>> +    char *name;
>> +    int type;
> This is wrong and won't work on big endian systems: Our EBML_UINT always
> expects a target element of type uint64_t.

Okay, will change to uint64_t.

I'm new to this, am I just supposed to update the patches locally and
send them as a new version once the whole series is reviewed?

Sorry, think I responded to the wrong email.