[FFmpeg-devel] [PATCH 1/1] librtmp: make flashVer case consistent

[Tristan Matthews]

On Sat, Apr 9, 2022 at 2:45 PM Marton Balint <cus at passwd.hu> wrote:

>
>
> On Wed, 6 Apr 2022, Tristan Matthews wrote:
>
> > This is basically a cosmetic change (no functional difference).
> >
> > ---
> > libavformat/librtmp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/libavformat/librtmp.c b/libavformat/librtmp.c
> > index 43013e46e0..b23adb9593 100644
> > --- a/libavformat/librtmp.c
> > +++ b/libavformat/librtmp.c
> > @@ -115,7 +115,7 @@ static int rtmp_open(URLContext *s, const char *uri,
> int flags)
> >     if (ctx->app)      len += strlen(ctx->app)      + sizeof(" app=");
> >     if (ctx->tcurl)    len += strlen(ctx->tcurl)    + sizeof(" tcUrl=");
> >     if (ctx->pageurl)  len += strlen(ctx->pageurl)  + sizeof("
> pageUrl=");
> > -    if (ctx->flashver) len += strlen(ctx->flashver) + sizeof("
> flashver=");
> > +    if (ctx->flashver) len += strlen(ctx->flashver) + sizeof("
> flashVer=");
>
> Actually this whole rtmp_open function should be reworked to use an
> AVBPrint buffer to generate the rtmp URL. The way it works now -
> calculating the length first then creating the actual sting - is
> very ugly.
>
>
Oh yeah good call, I will follow up with that instead.