[FFmpeg-devel] [PATCH v9 1/6] libavutil/wchar_filename.h: Add whcartoutf8, wchartoansi and utf8toansi

[nil-admirari at mailo.com]

> However while reviewing this, I noticed a preexisting issue regarding the 
> av_fopen_utf8 function. This patchset extends the use of that function 
> into fftools, which isn't great given the issue...

Reverted back to fopen().

> The other question is whether it's tolerable to use more non-installed 
> headers (like libavutil/wchar_filename.h) in fftools. (I'd like to have 
> this point confirmed with Anton before landing the patchset.)

Currently the header consist entirely of static inline functions. If it's not OK to use it here,
please suggest a better place for these functions.

> We don't generally use 'const' like this in ffmpeg; we use 'const' where 
> it makes a functional difference (i.e. on the type that pointers point 
> at), but not for plain scalar values (neither parameters nor local 
> variables).

Removed const from everywhere except pointer arguments.

> I think this actually would be more correct to use CP_ACP, not 
> CP_THREAD_ACP.

Changed to CP_ACP.

New version of the patch: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-April/295569.html.