[FFmpeg-devel] [PATCH] libavcodec/videotoolboxenc.c: add option to hevc encoder to prioritize speed.

[Simone Karin Lehmann]

> Am 25.04.2022 um 21:14 schrieb Rick Kern <kernrj at gmail.com>:
> 
>> 
>>    { "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc),
>> AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, VE },
>> +    { "prio_speed", "prioritize encoding speed", OFFSET(prio_speed),
>> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE },
>> 
> It might be simpler to make the default value of prio_speed -1, and set
> this property on the encoder session only when it's non-negative. Then we
> won't need to worry about the default value changing for different codecs
> or different OS versions. It could also be moved into COMMON_OPTIONS in
> this case.

oh yes, that’s way better. I didn’t think of that in the first place. Thanks for the hint.

Here’s the modified patch

Simone

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-add-options-to-h264-hevc-and-prores-encoders-to-prio.patch
Type: application/octet-stream
Size: 3219 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220425/c85d6673/attachment.obj>