[FFmpeg-devel] [PATCH v1 2/2] lavfi/overlay_vaapi: Set defalut alpha value as 1.0

[Wang, Fei W]

On Wed, 2022-07-27 at 18:51 +0530, Gyan Doshi wrote:
> Typo in title.
> 
> 
> 
> On 2022-07-27 06:06 pm, Fei Wang wrote:
> > Previous default value 0.0 means 100% transparency for overlaid
> > video,
> > which make overlaid invisible. Change to 1.0 will let output video
> > much
> > more clear and less confuse if user doesn't specify alpha value.
> 
> "
> The present default value of 0 will render the overlay video
> invisible. 
> A default of 1.0 is consistent with
> most common use cases.
> "

Fixed in V2.

Thanks
Fei

> 
> 
> > Signed-off-by: Fei Wang <fei.w.wang at intel.com>
> > ---
> >   doc/filters.texi               | 2 +-
> >   libavfilter/vf_overlay_vaapi.c | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/doc/filters.texi b/doc/filters.texi
> > index 47ac4dc7f4..76168955c6 100644
> > --- a/doc/filters.texi
> > +++ b/doc/filters.texi
> > @@ -26119,7 +26119,7 @@ Default value is the height of input
> > overlay video.
> >   @item alpha
> >   Set transparency of overlaid video. Allowed range is 0.0 to 1.0,
> >   higher value means lower transparency.
> > -Default value is @code{0.0}.
> > +Default value is @code{1.0}.
> >   
> >   @end table
> >   
> > diff --git a/libavfilter/vf_overlay_vaapi.c
> > b/libavfilter/vf_overlay_vaapi.c
> > index b3a624ae15..3e6a0de13f 100644
> > --- a/libavfilter/vf_overlay_vaapi.c
> > +++ b/libavfilter/vf_overlay_vaapi.c
> > @@ -380,7 +380,7 @@ static const AVOption overlay_vaapi_options[] =
> > {
> >       { "h", "Overlay height",
> >         OFFSET(overlay_oh), AV_OPT_TYPE_INT, { .i64 = 0 }, 0,
> > INT_MAX, .flags = FLAGS },
> >       { "alpha", "Overlay global alpha",
> > -      OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 0.0}, 0.0, 1.0,
> > .flags = FLAGS},
> > +      OFFSET(alpha), AV_OPT_TYPE_FLOAT, { .dbl = 1.0}, 0.0, 1.0,
> > .flags = FLAGS},
> >       { NULL },
> >   };
> >   
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".