[FFmpeg-devel] [PATCH] swscale/output: fix reading chroma values when generating vuya output

Martin Storsjö martin at martin.st
Mon Aug 8 15:36:52 EEST 2022


On Mon, 8 Aug 2022, James Almer wrote:

> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> libswscale/output.c                      | 4 ++--
> tests/ref/fate/filter-pixdesc-vuya       | 2 +-
> tests/ref/fate/filter-pixfmts-copy       | 2 +-
> tests/ref/fate/filter-pixfmts-crop       | 2 +-
> tests/ref/fate/filter-pixfmts-field      | 2 +-
> tests/ref/fate/filter-pixfmts-fieldorder | 2 +-
> tests/ref/fate/filter-pixfmts-hflip      | 2 +-
> tests/ref/fate/filter-pixfmts-il         | 2 +-
> tests/ref/fate/filter-pixfmts-null       | 2 +-
> tests/ref/fate/filter-pixfmts-pad        | 2 +-
> tests/ref/fate/filter-pixfmts-scale      | 2 +-
> tests/ref/fate/filter-pixfmts-transpose  | 2 +-
> tests/ref/fate/filter-pixfmts-vflip      | 2 +-
> 13 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/libswscale/output.c b/libswscale/output.c
> index 1b8f35bb4b..74f992ae80 100644
> --- a/libswscale/output.c
> +++ b/libswscale/output.c
> @@ -2602,10 +2602,10 @@ yuv2vuya_X_c(SwsContext *c, const int16_t *lumFilter,
>         for (j = 0; j < lumFilterSize; j++)
>             Y += lumSrc[j][i] * lumFilter[j];
>
> -        for (j = 0; j < lumFilterSize; j++)
> +        for (j = 0; j < chrFilterSize; j++)
>             U += chrUSrc[j][i] * chrFilter[j];
>
> -        for (j = 0; j < lumFilterSize; j++)
> +        for (j = 0; j < chrFilterSize; j++)
>             V += chrVSrc[j][i] * chrFilter[j];
>
>         Y >>= 19;

Thanks, this does indeed fix the failures on arm.

// Martin



More information about the ffmpeg-devel mailing list