[FFmpeg-devel] [PATCH 08/11] avutil/half2float: move non-inline init code out of header

[Michael Niedermayer]

On Mon, Aug 15, 2022 at 06:20:45AM +0200, Andreas Rheinhardt wrote:
> Michael Niedermayer:
> > On Thu, Aug 11, 2022 at 11:31:32PM +0200, Andreas Rheinhardt wrote:
[...]
> > make distclean ; ../configure --enable-shared --cc='ccache clang-6.0'  --enable-pthreads --samples=fate/fate-suite/ --enable-version3  --extra-cflags='-O1 -fno-omit-frame-pointer'  && make -j32
> > 
> > LD	ffmpeg_g
> > LD	ffplay_g
> > LD	ffprobe_g
> > libswscale/libswscale.so: undefined reference to `ff_init_half2float_tables'
> > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> > Makefile:131: recipe for target 'ffprobe_g' failed
> > make: *** [ffprobe_g] Error 1
> > make: *** Waiting for unfinished jobs....
> > libswscale/libswscale.so: undefined reference to `ff_init_half2float_tables'
> > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> > Makefile:131: recipe for target 'ffplay_g' failed
> > make: *** [ffplay_g] Error 1
> > libswscale/libswscale.so: undefined reference to `ff_init_half2float_tables'
> > clang: error: linker command failed with exit code 1 (use -v to see invocation)
> > Makefile:131: recipe for target 'ffmpeg_g' failed
> > make: *** [ffmpeg_g] Error 1
> > 
> > git grep ff_init_half2float_tables
> > libavcodec/exr.c:    ff_init_half2float_tables(&s->h2f_tables);
> > libavcodec/pnmdec.c:    ff_init_half2float_tables(&s->h2f_tables);
> > libavutil/half2float.c:void ff_init_half2float_tables(Half2FloatTables *t)
> > libavutil/half2float.h:void ff_init_half2float_tables(Half2FloatTables *t);
> > libswscale/slice.c:        ff_init_half2float_tables(c->h2f_tables);
> > 
> > libavcodec/half2float.c:#include "libavutil/half2float.c"
> > libswscale/half2float.c:#include "libavutil/half2float.c"
> > 
> > git grep half2float.o
> > libavcodec/Makefile:OBJS-$(CONFIG_EXR_DECODER)             += exr.o exrdsp.o half2float.o
> > libavcodec/Makefile:OBJS-$(CONFIG_PHM_DECODER)             += pnmdec.o pnm.o half2float.o
> > libavutil/Makefile:       half2float.o                                                     \
> > 
> > also i tried this:
> > -#include "libavutil/half2float.c"
> > +#inklude "libavutil/half2float.c"
> > 
> > and still it fails at linking stage not compile, really impressive the compiler
> > speaks german C too
> > 
> 
> No, the libswscale/half2float.c file is just not compiled at all, see above.

You seem to have a failure in humor.so

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is a danger to trust the dream we wish for rather than
the science we have, -- Dr. Kenneth Brown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220815/d8170719/attachment.sig>