[FFmpeg-devel] [PATCH v3 0/3] checkasm: updated tests for sw_scale

Martin Storsjö martin at martin.st
Tue Aug 16 13:41:10 EEST 2022


On Sat, 13 Aug 2022, Swinney, Jonathan wrote:

>> We don't generally use stdbool in ffmpeg, even if it's C99 - just use a
>> plain int and 0/1.
> Updated this.
>
>> Other than that, the checkasm changes look fine (I coauthored part of
>> them - and your cleanup of my WIP patch looks good!).
> Yes, thank you for the help on that!
>
>> Hmm, can you elaborate on this bit? With only the first patch applied, the
>> checkasm test still succeeds.
> That was leftover from when my test was broken. Is that that with the fixed
> test, it works fine.
>
>> Could we split this improvement for the existing codepath into a separate
>> preceding patch, to keep things a bit clearer?
> I split it out. Let me know if I didn't split like you intended.

Thanks, this looked good to me, so I pushed them!

// Martin



More information about the ffmpeg-devel mailing list