[FFmpeg-devel] [PATCH 1/2] avutil: move bswapdsp from avcodec to avutil

[Mark Reid]

On Mon, Dec 5, 2022 at 12:33 PM Michael Niedermayer <michael at niedermayer.cc>
wrote:

> On Sun, Dec 04, 2022 at 09:36:19PM -0800, mindmark at gmail.com wrote:
> > From: Mark Reid <mindmark at gmail.com>
> >
> > Also renamed bswap_buf to bswap32_buf
> > ---
> >  configure                                     | 56 ++++++++-----------
> >  libavcodec/4xm.c                              | 14 ++---
> >  libavcodec/Makefile                           |  1 -
> >  libavcodec/ac3dec.c                           |  4 +-
> >  libavcodec/ac3dec.h                           |  4 +-
> >  libavcodec/alsdec.c                           | 12 ++--
> >  libavcodec/apedec.c                           | 10 ++--
> >  libavcodec/asv.c                              |  4 +-
> >  libavcodec/asv.h                              |  4 +-
> >  libavcodec/asvdec.c                           |  4 +-
> >  libavcodec/asvenc.c                           |  4 +-
> >  libavcodec/cllc.c                             |  6 +-
> >  libavcodec/eamad.c                            |  6 +-
> >  libavcodec/eatqi.c                            | 10 ++--
> >  libavcodec/exr.c                              |  6 +-
> >  libavcodec/flacenc.c                          |  6 +-
> >  libavcodec/fraps.c                            | 10 ++--
> >  libavcodec/hevcdec.c                          |  4 +-
> >  libavcodec/hevcdec.h                          |  4 +-
> >  libavcodec/huffyuvdec.c                       | 14 ++---
> >  libavcodec/huffyuvenc.c                       |  8 +--
> >  libavcodec/imc.c                              |  6 +-
> >  libavcodec/imm4.c                             | 12 ++--
> >  libavcodec/mdec.c                             |  6 +-
> >  libavcodec/mimic.c                            | 12 ++--
> >  libavcodec/mobiclip.c                         |  6 +-
> >  libavcodec/motionpixels.c                     | 10 ++--
> >  libavcodec/mpc.h                              |  4 +-
> >  libavcodec/mpc7.c                             |  8 +--
> >  libavcodec/rawdec.c                           |  8 +--
> >  libavcodec/riscv/Makefile                     |  3 -
> >  libavcodec/shorten.c                          |  7 ++-
> >  libavcodec/truemotion2.c                      | 11 ++--
> >  libavcodec/truespeech.c                       |  8 +--
> >  libavcodec/utvideo.h                          |  4 +-
> >  libavcodec/utvideodec.c                       | 16 +++---
> >  libavcodec/utvideoenc.c                       | 10 ++--
> >  libavcodec/x86/Makefile                       |  2 -
> >  libavcodec/ylc.c                              | 18 +++---
> >  libavutil/Makefile                            |  2 +
> >  {libavcodec => libavutil}/bswapdsp.c          | 17 +++---
> >  {libavcodec => libavutil}/bswapdsp.h          | 16 +++---
> >  libavutil/riscv/Makefile                      |  7 ++-
> >  .../riscv/bswapdsp_init.c                     |  9 +--
> >  .../riscv/bswapdsp_rvb.S                      |  0
> >  .../riscv/bswapdsp_rvv.S                      |  0
> >  libavutil/version.h                           |  2 +-
> >  libavutil/x86/Makefile                        |  8 ++-
> >  {libavcodec => libavutil}/x86/bswapdsp.asm    |  2 +-
> >  {libavcodec => libavutil}/x86/bswapdsp_init.c | 17 +++---
> >  tests/checkasm/Makefile                       |  2 +-
> >  tests/checkasm/bswapdsp.c                     |  8 +--
> >  tests/checkasm/checkasm.c                     |  4 +-
> >  53 files changed, 216 insertions(+), 220 deletions(-)
> >  rename {libavcodec => libavutil}/bswapdsp.c (80%)
> >  rename {libavcodec => libavutil}/bswapdsp.h (71%)
> >  rename {libavcodec => libavutil}/riscv/bswapdsp_init.c (85%)
> >  rename {libavcodec => libavutil}/riscv/bswapdsp_rvb.S (100%)
> >  rename {libavcodec => libavutil}/riscv/bswapdsp_rvv.S (100%)
> >  rename {libavcodec => libavutil}/x86/bswapdsp.asm (98%)
> >  rename {libavcodec => libavutil}/x86/bswapdsp_init.c (80%)
>
> Fails to build with shared libs
> LD      ffmpeg_g
> libavutil/libavutil.so: undefined reference to `ff_pb_80'
> clang: error: linker command failed with exit code 1 (use -v to see
> invocation)
> Makefile:131: recipe for target 'ffmpeg_g' failed
> make: *** [ffmpeg_g] Error 1
>
>
I see what's going on. I think I haven't been getting that error because
I've been building statically.



> [...]
>
> --
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Let us carefully observe those good qualities wherein our enemies excel us
> and endeavor to excel them, by avoiding what is faulty, and imitating what
> is excellent in them. -- Plutarch
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".
>