[FFmpeg-devel] [PATCH v2 1/2] avutil: move bswapdsp from avcodec to avutil

Michael Niedermayer michael at niedermayer.cc
Tue Dec 6 20:21:15 EET 2022


On Mon, Dec 05, 2022 at 02:16:40PM -0800, mindmark at gmail.com wrote:
> From: Mark Reid <mindmark at gmail.com>
> 
> Also renamed bswap_buf to bswap32_buf
> ---
>  configure                                     | 56 ++++++++-----------
>  libavcodec/4xm.c                              | 14 ++---
>  libavcodec/Makefile                           |  1 -
>  libavcodec/ac3dec.c                           |  4 +-
>  libavcodec/ac3dec.h                           |  4 +-
>  libavcodec/alsdec.c                           | 12 ++--
>  libavcodec/apedec.c                           | 10 ++--
>  libavcodec/asv.c                              |  4 +-
>  libavcodec/asv.h                              |  4 +-
>  libavcodec/asvdec.c                           |  4 +-
>  libavcodec/asvenc.c                           |  4 +-
>  libavcodec/cllc.c                             |  6 +-
>  libavcodec/eamad.c                            |  6 +-
>  libavcodec/eatqi.c                            | 10 ++--
>  libavcodec/exr.c                              |  6 +-
>  libavcodec/flacenc.c                          |  6 +-
>  libavcodec/fraps.c                            | 10 ++--
>  libavcodec/hevcdec.c                          |  4 +-
>  libavcodec/hevcdec.h                          |  4 +-
>  libavcodec/huffyuvdec.c                       | 14 ++---
>  libavcodec/huffyuvenc.c                       |  8 +--
>  libavcodec/imc.c                              |  6 +-
>  libavcodec/imm4.c                             | 12 ++--
>  libavcodec/mdec.c                             |  6 +-
>  libavcodec/mimic.c                            | 12 ++--
>  libavcodec/mobiclip.c                         |  6 +-
>  libavcodec/motionpixels.c                     | 10 ++--
>  libavcodec/mpc.h                              |  4 +-
>  libavcodec/mpc7.c                             |  8 +--
>  libavcodec/rawdec.c                           |  8 +--
>  libavcodec/riscv/Makefile                     |  3 -
>  libavcodec/shorten.c                          |  7 ++-
>  libavcodec/truemotion2.c                      | 11 ++--
>  libavcodec/truespeech.c                       |  8 +--
>  libavcodec/utvideo.h                          |  4 +-
>  libavcodec/utvideodec.c                       | 16 +++---
>  libavcodec/utvideoenc.c                       | 10 ++--
>  libavcodec/x86/Makefile                       |  2 -
>  libavcodec/ylc.c                              | 18 +++---
>  libavutil/Makefile                            |  2 +
>  {libavcodec => libavutil}/bswapdsp.c          | 17 +++---
>  {libavcodec => libavutil}/bswapdsp.h          | 16 +++---
>  libavutil/riscv/Makefile                      |  7 ++-
>  .../riscv/bswapdsp_init.c                     |  9 +--
>  .../riscv/bswapdsp_rvb.S                      |  0
>  .../riscv/bswapdsp_rvv.S                      |  0
>  libavutil/version.h                           |  2 +-
>  libavutil/x86/Makefile                        |  8 ++-
>  {libavcodec => libavutil}/x86/bswapdsp.asm    |  4 +-
>  {libavcodec => libavutil}/x86/bswapdsp_init.c | 17 +++---
>  tests/checkasm/Makefile                       |  2 +-
>  tests/checkasm/bswapdsp.c                     |  8 +--
>  tests/checkasm/checkasm.c                     |  4 +-
>  53 files changed, 216 insertions(+), 222 deletions(-)
>  rename {libavcodec => libavutil}/bswapdsp.c (80%)
>  rename {libavcodec => libavutil}/bswapdsp.h (71%)
>  rename {libavcodec => libavutil}/riscv/bswapdsp_init.c (85%)
>  rename {libavcodec => libavutil}/riscv/bswapdsp_rvb.S (100%)
>  rename {libavcodec => libavutil}/riscv/bswapdsp_rvv.S (100%)
>  rename {libavcodec => libavutil}/x86/bswapdsp.asm (97%)
>  rename {libavcodec => libavutil}/x86/bswapdsp_init.c (80%)
> 
> diff --git a/configure b/configure
> index f4eedfc207..03b502ea37 100755
> --- a/configure
> +++ b/configure
> @@ -2421,7 +2421,6 @@ CONFIG_EXTRA="
>      audio_frame_queue
>      audiodsp
>      blockdsp
> -    bswapdsp
>      cabac
>      cbs
>      cbs_av1
> @@ -2749,8 +2748,8 @@ aac_decoder_select="adts_header mpeg4audio sinewin"
>  aac_fixed_decoder_select="adts_header mpeg4audio"
>  aac_encoder_select="audio_frame_queue iirfilter lpc sinewin"
>  aac_latm_decoder_select="aac_decoder aac_latm_parser"
> -ac3_decoder_select="ac3_parser ac3dsp bswapdsp fmtconvert"
> -ac3_fixed_decoder_select="ac3_parser ac3dsp bswapdsp"
> +ac3_decoder_select="ac3_parser ac3dsp fmtconvert"
> +ac3_fixed_decoder_select="ac3_parser ac3dsp"
>  ac3_encoder_select="ac3dsp audiodsp me_cmp"
>  ac3_fixed_encoder_select="ac3dsp audiodsp me_cmp"
>  acelp_kelvin_decoder_select="audiodsp"
> @@ -2759,20 +2758,20 @@ adpcm_g722_encoder_select="g722dsp"
>  agm_decoder_select="idctdsp"
>  aic_decoder_select="golomb idctdsp"
>  alac_encoder_select="lpc"
> -als_decoder_select="bswapdsp mpeg4audio"
> +als_decoder_select="mpeg4audio"
>  amrnb_decoder_select="lsp"
>  amrwb_decoder_select="lsp"
>  amv_decoder_select="sp5x_decoder exif"
>  amv_encoder_select="jpegtables mpegvideoenc"
> -ape_decoder_select="bswapdsp llauddsp"
> +ape_decoder_select="llauddsp"
>  apng_decoder_select="inflate_wrapper"
>  apng_encoder_select="deflate_wrapper llvidencdsp"
>  aptx_encoder_select="audio_frame_queue"
>  aptx_hd_encoder_select="audio_frame_queue"

> -asv1_decoder_select="blockdsp bswapdsp idctdsp"
> +asv1_decoder_select="idctdsp"

blockdsp is disappearing here, i dont think that should happen in this patch

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Let us carefully observe those good qualities wherein our enemies excel us
and endeavor to excel them, by avoiding what is faulty, and imitating what
is excellent in them. -- Plutarch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221206/f333a20f/attachment.sig>


More information about the ffmpeg-devel mailing list