[FFmpeg-devel] [PATCH] avformat: Rename IPFS to IPFS gateway

Derek Buitenhuis derek.buitenhuis at gmail.com
Fri Dec 9 17:52:05 EET 2022


On 12/9/2022 3:45 PM, Nicolas George wrote:
>> -static int ipfs_read(URLContext *h, unsigned char *buf, int size)
>> +static int ipfs_gateway_read(URLContext *h, unsigned char *buf, int size)
> 
> There is no need to rename local symbols.

My intent was to rename in case we ever got an actual IPFS implementation,
but I have no strong opinion on whether to keep this part of the patch or
not.

>> +const URLProtocol ff_ipfs_gateway_protocol = {
>> +    .name               = "ipfs_gateway",
> 
> It is a bit of a mouthful. Maybe "ipfsgw"?

My personal preference is verbosity here, but it's not a strong preference.

- Derek


More information about the ffmpeg-devel mailing list