[FFmpeg-devel] [PATCH] avformat: Rename IPFS to IPFS gateway

Tomas Härdin git at haerdin.se
Wed Dec 14 19:34:36 EET 2022


tis 2022-12-13 klockan 12:48 +0000 skrev Derek Buitenhuis:
> On 12/13/2022 12:44 PM, Derek Buitenhuis wrote:
> > I'll push with the internal symbol renames removed later today
> > if nobody objects.
> 
> [...]
> 
> > -const URLProtocol ff_ipfs_protocol = {
> > -    .name               = "ipfs",
> > +const URLProtocol ff_ipfs_gateway_protocol = {
> > +    .name               = "ipfs_gateway",
> 
> Actually, would this break ipfs:// urls? Might need to remove this,
> too.

This is why I objected to this nonsense in the first place. Business
logic doesn't belong in lavf.

/Tomass



More information about the ffmpeg-devel mailing list