[FFmpeg-devel] [PATCH] lavc/videotoolbox: validate vt context in the decoder callback

Alessandro Di Nepi alessandro.dinepi at gmail.com
Thu Dec 15 16:16:21 EET 2022


Ping on this,
Can I contribute somehow either to fix calling `av_videotoolbox_default_init` or at least update the docs?

Best Regards,
Alessandro
On 11 Dec 2022, 11:57 +0200, Alessandro Di Nepi <alessandro.dinepi at gmail.com>, wrote:
> On 9 Dec 2022, 6:45 +0200, FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>, wrote:
> > Did you call av_videotoolbox_default_init() or av_videotoolbox_default_init2()?
> Actually yes, I call `av_videotoolbox_default_init(context);`
> > I think that’s why avctx->internal->hwaccel_priv_data is NULL. That code path is broken.
> > Does remove the call of av_videotoolbox_default_init()/av_videotoolbox_default_init2() works for you?
> Definitively yes, if I remove the call to `av_videotoolbox_default_init` the context is fine.
>
> Thanks for sorting this out. I'd like to contribute and have this fixed or documented for other people.
> What should be the desired behavior? Calling `av_videotoolbox_default_init` and having the context not NULL?
> Or shall we remove the init at all?
>
> Best Regards


More information about the ffmpeg-devel mailing list