[FFmpeg-devel] 答复: [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils: add -mask_url to replace the protocol address in the command with the asterisk (*)

[Nicolas George]

Wujian(Chin) (12022-12-20):
>   I think that it's more concise to use code this way.

Concision is not the goal here, maintainability is. Please do not use
gotos.

>  I think that it would be better to replace the entire url, so that the code implementation is simple.

Then replace the whole command line, it is even simpler. Also, this way
you miss credentials passed through options.

> >> +    argv2 = av_mallocz(argc * sizeof(char *));
> 
> >sizeof(*argv2)

Youhoud?

>  This option needs to replace the URL. It is more appropriate to judge
>  mask_url and copy argv in this place. Otherwise, do you have any
>  other suggestions?

Use the normal options parsing system.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221222/9b011be4/attachment.sig>