[FFmpeg-devel] [PATCH] fftools/ffmpeg_ffplay_ffprobe_cmdutils:add -mask_url to replace the protocol address in the command with the asterisk (*)

Nicolas George george at nsup.org
Thu Dec 22 21:28:09 EET 2022


Wujian(Chin) (12022-12-21):
> I have modified the issues again. Please review it again. Thank you.
> 
> If the protocol address contains the user name and password, the ps -ef
> command exposes plaintext. The -mask_url parameter option is added to
> replace the protocol address in the command line with the asterisk (*).
> Because other users can run the ps -ef command to view sensitive
> information such as the user name and password in the protocol address,
> which is insecure.
> 
> Signed-off-by: wujian_nanjing <wujian2 at huawei.com>
> ---
>  doc/fftools-common-opts.texi | 11 +++++++
>  fftools/cmdutils.c           | 75 ++++++++++++++++++++++++++++++++++++++++++--
>  fftools/cmdutils.h           | 25 +++++++++++++++
>  fftools/ffmpeg.c             | 10 +++---
>  fftools/ffplay.c             |  9 ++++--
>  fftools/ffprobe.c            | 10 +++---
>  6 files changed, 126 insertions(+), 14 deletions(-)

This new patch still has issues not addressed since the first review.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20221222/cd602435/attachment.sig>


More information about the ffmpeg-devel mailing list