[FFmpeg-devel] [PATCH 4/4] lavc: deprecate FF_IDCT_NONE

[James Almer]

On 2/1/2022 8:16 AM, Lynne wrote:
> 1 Feb 2022, 11:02 by anton at khirnov.net:
> 
>> It was only used by XvMC.
>> ---
>>   libavcodec/avcodec.h | 5 ++++-
>>   libavcodec/idctdsp.c | 1 -
>>   libavcodec/version.h | 1 +
>>   3 files changed, 5 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index acb7ae0e14..5362446092 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -1407,7 +1407,10 @@ typedef struct AVCodecContext {
>>   #define FF_IDCT_SIMPLEARMV6   17
>>   #define FF_IDCT_FAAN          20
>>   #define FF_IDCT_SIMPLENEON    22
>> -#define FF_IDCT_NONE          24 /* Used by XvMC to extract IDCT coefficients with FF_IDCT_PERM_NONE */
>> +#if FF_API_IDCT_NONE
>> +// formerly used by xvmc
>> +#define FF_IDCT_NONE          24
>> +#endif
>>   #define FF_IDCT_SIMPLEAUTO    128
>>
> 
> Isn't this a private define that clients weren't meant to use?

Nowhere it says that. All FF_IDCT_ defines are documented as being able 
to be used in AVCodecContext.idct_algo

> If so, may as well drop it with patch #1
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".