[FFmpeg-devel] [PATCH v2 1/1] avformat: Add IPFS protocol support.

[Timo Rothenpieler]

On 01.02.2022 22:58, Mark Gaiser wrote:
> +static int translate_ipfs_to_http(URLContext *h, const char *uri, int flags, AVDictionary **options)
> +{
> +    const char *ipfs_cid;
> +    const char *protocol_path_suffix = "ipfs/";
> +    char *fulluri;
> +    int ret;
> +    Context *c = h->priv_data;
> +    int is_ipfs = (av_strstart(uri, "ipfs://", &ipfs_cid) || av_strstart(uri, "ipfs:", &ipfs_cid));
> +    int is_ipns = (av_strstart(uri, "ipns://", &ipfs_cid) || av_strstart(uri, "ipns:", &ipfs_cid));

What's the point of this logic?
The first half of each check seems pointless, since the second half is 
true for everything the first one would cover.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4494 bytes
Desc: S/MIME Cryptographic Signature
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220202/b8221fc1/attachment.bin>