[FFmpeg-devel] [PATCH] avfilter/framepool: fix adjustment that can crash filtering

[Anton Khirnov]

Quoting Paul B Mahol (2022-02-18 11:46:05)
> Fixes #9551.
> 
> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  libavfilter/framepool.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavfilter/framepool.c b/libavfilter/framepool.c
> index 7c63807df3..aab408d355 100644
> --- a/libavfilter/framepool.c
> +++ b/libavfilter/framepool.c
> @@ -96,7 +96,7 @@ FFFramePool *ff_frame_pool_video_init(AVBufferRef* (*alloc)(size_t size),
>          if (i == 1 || i == 2)
>              h = AV_CEIL_RSHIFT(h, desc->log2_chroma_h);
>  
> -        pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + 16 + 16 - 1,
> +        pool->pools[i] = av_buffer_pool_init(pool->linesize[i] * h + 16 + 16 - 0,
>                                               alloc);

all these magic constants are extremely non-obvious, why are they there
and why does removing that 1 crash anything?

-- 
Anton Khirnov