[FFmpeg-devel] [PATCH v2 1/5] avutil: [loongarch] Update loongson_intrinsics.h to v1.1.0

Hao Chen chenhao at loongson.cn
Fri Feb 25 05:20:24 EET 2022


Thanks for your advices. This file is used by many projects, including 
Google.

In order to facilitate the merger of the Google community, this file is 
adopted to the Google coding style.

It will be troublesome for us to modify and maintain it, if the 
community is very concerned about this coding style.

在 2022/2/21 下午11:00, Michael Niedermayer 写道:
> On Thu, Feb 17, 2022 at 07:11:47PM +0800, Hao Chen wrote:
>> The loongson_intrinsics.h file is updated from v1.0.3 version
>> to v1.1.0. Some spelling mistakes are fixed and new functions are added.
>>
>> Signed-off-by: Hao Chen <chenhao at loongson.cn>
>> ---
>>   libavutil/loongarch/loongson_intrinsics.h | 1697 +++++++++++----------
>>   1 file changed, 884 insertions(+), 813 deletions(-)
>>
>> diff --git a/libavutil/loongarch/loongson_intrinsics.h b/libavutil/loongarch/loongson_intrinsics.h
>> index 6e0439f829..eb256863c8 100644
>> --- a/libavutil/loongarch/loongson_intrinsics.h
>> +++ b/libavutil/loongarch/loongson_intrinsics.h
>> @@ -33,7 +33,7 @@
>>    *                Xiwei Gu   <guxiwei-hf at loongson.cn>
>>    *                Lu Wang    <wanglu at loongson.cn>
>>    *
>> - * This file is a header file for loongarch builtin extention.
>> + * This file is a header file for loongarch builtin extension.
>>    *
>>    */
>>   
>> @@ -42,50 +42,50 @@
>>   
>>   /**
>>    * MAJOR version: Macro usage changes.
>> - * MINOR version: Add new functions, or bug fix.
>> + * MINOR version: Add new functions, or bug fixes.
>>    * MICRO version: Comment changes or implementation changes.
>>    */
>>   #define LSOM_VERSION_MAJOR 1
>> -#define LSOM_VERSION_MINOR 0
>> -#define LSOM_VERSION_MICRO 3
>> +#define LSOM_VERSION_MINOR 1
>> +#define LSOM_VERSION_MICRO 0
>>   
>>   #define DUP2_ARG1(_INS, _IN0, _IN1, _OUT0, _OUT1) \
>> -{ \
>> -    _OUT0 = _INS(_IN0); \
>> -    _OUT1 = _INS(_IN1); \
>> -}
>> +  {                                               \
>> +    _OUT0 = _INS(_IN0);                           \
>> +    _OUT1 = _INS(_IN1);                           \
>> +  }
>>   
>>   #define DUP2_ARG2(_INS, _IN0, _IN1, _IN2, _IN3, _OUT0, _OUT1) \
>> -{ \
>> -    _OUT0 = _INS(_IN0, _IN1); \
>> -    _OUT1 = _INS(_IN2, _IN3); \
>> -}
>> +  {                                                           \
>> +    _OUT0 = _INS(_IN0, _IN1);                                 \
>> +    _OUT1 = _INS(_IN2, _IN3);                                 \
>> +  }
> These style changes differ from the recommandition in doc/developer.texi
> is that intentional ?
>
> thx
>
> [...]
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".


More information about the ffmpeg-devel mailing list