[FFmpeg-devel] [PATCH] avformat/avidec: Check height

Michael Niedermayer michael at niedermayer.cc
Mon Feb 28 02:00:52 EET 2022


Fixes: negation of -2147483648 cannot be represented in type 'int'; cast to an unsigned type to negate this value to itself
Fixes: Ticket8486

Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
---
 libavformat/avidec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/avidec.c b/libavformat/avidec.c
index 0f0e6846da..455dce0733 100644
--- a/libavformat/avidec.c
+++ b/libavformat/avidec.c
@@ -862,6 +862,8 @@ static int avi_read_header(AVFormatContext *s)
                             memcpy(st->codecpar->extradata + st->codecpar->extradata_size - 9,
                                    "BottomUp", 9);
                     }
+                    if (st->codecpar->height == INT_MIN)
+                        return AVERROR_INVALIDDATA;
                     st->codecpar->height = FFABS(st->codecpar->height);
 
 //                    avio_skip(pb, size - 5 * 4);
-- 
2.17.1



More information about the ffmpeg-devel mailing list