[FFmpeg-devel] [PATCH v2 1/5] avutil: [loongarch] Update loongson_intrinsics.h to v1.1.0

[Michael Niedermayer]

On Mon, Feb 28, 2022 at 04:19:55PM +0800, 殷时友 wrote:
> 
> 
> > 2022年2月21日 下午11:00，Michael Niedermayer <michael at niedermayer.cc> 写道：
> > 
> > On Thu, Feb 17, 2022 at 07:11:47PM +0800, Hao Chen wrote:
> >> The loongson_intrinsics.h file is updated from v1.0.3 version
> >> to v1.1.0. Some spelling mistakes are fixed and new functions are added.
> >> 
> >> Signed-off-by: Hao Chen <chenhao at loongson.cn>
> >> ---
> >> libavutil/loongarch/loongson_intrinsics.h | 1697 +++++++++++----------
> >> 1 file changed, 884 insertions(+), 813 deletions(-)
> >> 
> >> diff --git a/libavutil/loongarch/loongson_intrinsics.h b/libavutil/loongarch/loongson_intrinsics.h
> >> index 6e0439f829..eb256863c8 100644
> >> --- a/libavutil/loongarch/loongson_intrinsics.h
> >> +++ b/libavutil/loongarch/loongson_intrinsics.h
> >> @@ -33,7 +33,7 @@
> >>  *                Xiwei Gu   <guxiwei-hf at loongson.cn>
> >>  *                Lu Wang    <wanglu at loongson.cn>
> >>  *
> >> - * This file is a header file for loongarch builtin extention.
> >> + * This file is a header file for loongarch builtin extension.
> >>  *
> >>  */
> >> 
> >> @@ -42,50 +42,50 @@
> >> 
> >> /**
> >>  * MAJOR version: Macro usage changes.
> >> - * MINOR version: Add new functions, or bug fix.
> >> + * MINOR version: Add new functions, or bug fixes.
> >>  * MICRO version: Comment changes or implementation changes.
> >>  */
> >> #define LSOM_VERSION_MAJOR 1
> >> -#define LSOM_VERSION_MINOR 0
> >> -#define LSOM_VERSION_MICRO 3
> >> +#define LSOM_VERSION_MINOR 1
> >> +#define LSOM_VERSION_MICRO 0
> >> 
> >> #define DUP2_ARG1(_INS, _IN0, _IN1, _OUT0, _OUT1) \
> >> -{ \
> >> -    _OUT0 = _INS(_IN0); \
> >> -    _OUT1 = _INS(_IN1); \
> >> -}
> >> +  {                                               \
> >> +    _OUT0 = _INS(_IN0);                           \
> >> +    _OUT1 = _INS(_IN1);                           \
> >> +  }
> >> 
> >> #define DUP2_ARG2(_INS, _IN0, _IN1, _IN2, _IN3, _OUT0, _OUT1) \
> >> -{ \
> >> -    _OUT0 = _INS(_IN0, _IN1); \
> >> -    _OUT1 = _INS(_IN2, _IN3); \
> >> -}
> >> +  {                                                           \
> >> +    _OUT0 = _INS(_IN0, _IN1);                                 \
> >> +    _OUT1 = _INS(_IN2, _IN3);                                 \
> >> +  }
> > 
> > These style changes differ from the recommandition in doc/developer.texi
> > is that intentional ?
> > 
> > thx
> 
> 
> Can we keep this style in here, it’s helpful for us to maintain this header file
> which used for some other projects too. Thanks very much.

yes, it makes sense to keep the style under these circumstances

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In a rich man's house there is no place to spit but his face.
-- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220228/98332286/attachment.sig>