[FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't dump images to disk based on DEBUG define

[Hendrik Leppkes]

On Fri, Jan 7, 2022 at 5:14 PM Soft Works <softworkz at hotmail.com> wrote:
>
>
>
> > -----Original Message-----
> > From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of Hendrik
> > Leppkes
> > Sent: Friday, January 7, 2022 11:32 AM
> > To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> > Subject: Re: [FFmpeg-devel] [PATCH 0/4] avcodec/dvbsubdec, dvdsubdec: don't
> > dump images to disk based on DEBUG define
> >
> > On Fri, Jan 7, 2022 at 11:20 AM Hendrik Leppkes <h.leppkes at gmail.com> wrote:
> > >
> > > On Fri, Jan 7, 2022 at 5:50 AM ffmpegagent <ffmpegagent at gmail.com> wrote:
> > > >
> > > > It's annoying and unexpected, but still useful at times (as I've realized
> > > > just recently).
> > > >
> > > > This is a follow-up to the earlier submission here:
> > > > https://www.mail-archive.com/ffmpeg-devel@ffmpeg.org/msg128080.html
> > > >
> > > > There has been a comment from Anton, questioning whether the dump-feature
> > is
> > > > useful. Meanwhile I came to the conclusion that it can be useful in-fact.
> > It
> > > > just shouldn't happen automatically when DEBUG is defined. That's what
> > these
> > > > patches do.
> > > >
> > > > I also added fixes for the fopen() call.
> > > >
> > > > softworkz (4):
> > > >   avcodec/dvbsubdec: don't dump images to disk based on DEBUG define
> > > >   avcodec/dvbsubdec: fix writing ppm
> > > >   avcodec/dvdsubdec: don't dump images to disk based on DEBUG define
> > > >   avcodec/dvdsubdec: fix writing ppm
> > > >
> > > >  libavcodec/dvbsubdec.c | 20 +++++++++++++-------
> > > >  libavcodec/dvdsubdec.c | 11 ++++++++---
> > > >  2 files changed, 21 insertions(+), 10 deletions(-)
> > > >
> > > >
> > >
> > > These patches need some squasing. It should've been obvious from them
> > > being duplicated.
> > >
> >
> > Actually I fell into the dvb dvd trap, but regardless the patches are
> > basically identical, so I would still squash them, personally.
>
> No problem, but in which way?
>
> 1. All 4 commits into a single one
> 2. 4 >> 2 horizontally (a single one for the debug commits and a single
>    one for the fopen commits)
> 3. 4 >> 2 vertically (a single commit for dvb and a single one for dvd)
>

I figured combining the patches that do the exact same thing for the
two different decoders.

- Hendrik