[FFmpeg-devel] [PATCH 1/5] libavdevice/avfoundation.m: use setAudioSettings, extend supported formats

Andreas Rheinhardt andreas.rheinhardt at outlook.com
Wed Jan 19 16:28:45 EET 2022


Romain Beauxis:
> This patch switches the logic around audio settings to let the caller drive the 
> format.
> 
> After experimenting with the AudioConverter, we realized that, even when 
> adhering to a strict implementation of the documented API, we were still getting 
> errors during conversions. The input device would randomly change from e.g. 
> s32le to s24le between restarts and error out on conversion (using a freshly 
> initialized converter).
> 
> Using setAudioSettings allow the OS to drive audio conversion internally and 
> pick whatever appropriate settings for the audio device. This has been working 
> very well and is also the way AVFoundation audio input is setup in videolan.
> 

Your mail is broken: we don't want patches as eml; instead you should
attach what git format-patch produces. Or you can use git send-email
directly.

- Andreas


More information about the ffmpeg-devel mailing list