[FFmpeg-devel] [PATCH 2/3] avfilter/af_apsyclip: fix peak overestimation

Jason Jang jcj83429 at gmail.com
Sat Jan 29 03:12:41 EET 2022


Ignore more samples that are near the edge of the block. The reason
is that the filtering tends to cause these samples to go above the
window more than the samples near the middle. If these samples are
included in the unwindowed peak estimation, the peak can be
overestimated. Because the block is windowed again before
overlapping, overshoots near the edge of the block are not very
important.

0.1 is the value from the version originally contributed to calf.

Signed-off-by: Jason Jang <jcj83429 at gmail.com>
---
 libavfilter/af_apsyclip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavfilter/af_apsyclip.c b/libavfilter/af_apsyclip.c
index 0bc469c..2a79ed3 100644
--- a/libavfilter/af_apsyclip.c
+++ b/libavfilter/af_apsyclip.c
@@ -87,7 +87,7 @@ static void generate_hann_window(float *window, float *inv_window, int size)
 
         window[i] = value;
         // 1/window to calculate unwindowed peak.
-        inv_window[i] = value > 0.01f ? 1.f / value : 0.f;
+        inv_window[i] = value > 0.1f ? 1.f / value : 0.f;
     }
 }
 
-- 
2.35.0



More information about the ffmpeg-devel mailing list