[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: Fix audio_drift_threshold check

[Michael Niedermayer]

On Sat, Jul 02, 2022 at 10:38:26AM +0200, Anton Khirnov wrote:
> Quoting Michael Niedermayer (2022-07-01 21:53:00)
> > On Thu, Jun 30, 2022 at 10:55:46AM +0200, Anton Khirnov wrote:
> > > Variant 2 is less bad, but the whole check seems hacky to me, since it
> > > seems to make assumptions about swr defaults
> > > 
> > > Won't setting this unconditionally have the same effect?
> > 
> > it has the same effect but its not so nice to the user to recommand extra
> > arguments which make no difference
> 
> Sorry, I don't follow. What is recommending any arguments to the user
> here?

i meant this thing here:
./ffmpeg   -i matrixbench_mpeg2.mpg -async 1 -f null -  2>&1 | grep async

-async is forwarded to lavfi similarly to -af aresample=async=1:min_hard_comp=0.100000:first_pts=0.

vs.

-async is forwarded to lavfi similarly to -af aresample=async=1:first_pts=0.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Observe your enemies, for they first find out your faults. -- Antisthenes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220702/ea100d95/attachment.sig>