[FFmpeg-devel] [PATCH] libavcodec/qsvenc: Fix a log format issue

"zhilizhao(赵志立)" quinkblack at foxmail.com
Thu Jul 7 10:37:29 EEST 2022



> On Jul 7, 2022, at 1:57 PM, Wenbin Chen <wenbin.chen-at-intel.com at ffmpeg.org> wrote:
> 
> Add a line feed to fix a log format issue.
> 
> Signed-off-by: Wenbin Chen <wenbin.chen at intel.com>
> ---
> libavcodec/qsvenc.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
> index 2382c2f5f7..81d93235d7 100644
> --- a/libavcodec/qsvenc.c
> +++ b/libavcodec/qsvenc.c
> @@ -308,6 +308,7 @@ static void dump_video_param(AVCodecContext *avctx, QSVEncContext *q,
>         case MFX_B_REF_PYRAMID: av_log(avctx, AV_LOG_VERBOSE, "pyramid");   break;
>         default:                av_log(avctx, AV_LOG_VERBOSE, "auto");      break;
>         }
> +        av_log(avctx, AV_LOG_VERBOSE, "\n");

It’s not thread safe. There are multiple such cases, better be fixed together.

> 
>         av_log(avctx, AV_LOG_VERBOSE,
>                "MinQPI: %"PRIu8"; MaxQPI: %"PRIu8"; MinQPP: %"PRIu8"; MaxQPP: %"PRIu8"; MinQPB: %"PRIu8"; MaxQPB: %"PRIu8"\n",
> -- 
> 2.32.0
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request at ffmpeg.org with subject "unsubscribe".



More information about the ffmpeg-devel mailing list