[FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter, lavfi.c wrapped_avframe and dependent changes

[Soft Works]

> -----Original Message-----
> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> Timo Rothenpieler
> Sent: Saturday, July 9, 2022 1:49 AM
> To: ffmpeg-devel at ffmpeg.org
> Subject: Re: [FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter,
> lavfi.c wrapped_avframe and dependent changes
> 
> On 09.07.2022 01:46, Soft Works wrote:
> >
> >
> >> -----Original Message-----
> >> From: ffmpeg-devel <ffmpeg-devel-bounces at ffmpeg.org> On Behalf Of
> >> Timo Rothenpieler
> >> Sent: Saturday, July 9, 2022 12:54 AM
> >> To: ffmpeg-devel at ffmpeg.org
> >> Cc: Timo Rothenpieler <timo at rothenpieler.org>
> >> Subject: [FFmpeg-devel] [PATCH v2 0/8] ddagrab source filter,
> lavfi.c
> >> wrapped_avframe and dependent changes
> >>
> >> Since a bunch small stuff has changed since the last time I sent
> >> these
> >> one by one, here's the whole collection again.
> >> I intend to push the whole lot within the next 48h, so they all
> make
> >
> > 48h?
> >
> > If I'm not mistaken, the first submission was just two days ago:
> 
> Yeah, and then a release deadline came up.
> 
> > avutil/hwcontext_d3d11va: fix texture_infos writes on non-fixed-
> size pools
> >
> > I hadn't seen that one before:
> >
> > avutil/hwcontext_d3d11va: update hwctx flags from input texture
> 
> Those were already discussed on IRC, and are basically fixing up a
> mess
> that was made when adding QSV interop.

This was my code which I had done in 2019 and Intel had later adopted
it.

One Part of the 5% differences where the deviated from my implementation
was -- guess what: Setting of those flags...


> Right now it just trashes the heap without those patches.
> 
> Just look at all the stuff happening in the qsv hwcontext.
> It relies on all of those flags being correct, but only did the bare
> minimum to ensure that.
> So this is a bunch of missing bits and pieces to at least not make it
> crash and burn.

I can submit the missing bit of differences as a patch. I thought
it was no longer needed. The requirements have also changed over
MSDK versions. The 8bit file mapping that I've shown recently exists
in fact because an earlier MSDK version was requesting such texture.

Anyway, when something is causing trouble, then it should be fixed 
in hwcontext_qsv.

Thanks,
sw