[FFmpeg-devel] [PATCH] Make implicit void pointer cast explicit

Nicolas George george at nsup.org
Wed Jul 20 12:01:04 EEST 2022


Amir Mazzarella (12022-07-19):
> I understand that FFmpeg does not contain accommodations, but in my
> opinion it is less of an accommodation and more for readability, avoiding
> an implicit cast. An explicit void pointer cast, like the one presented in

The arguments against useless casts have been worded a thousand times,
let us not waste everybody's energy with one more.

> my patch, is done elsewhere in FFmpeg code as well.
> See https://github.com/FFmpeg/FFmpeg/blob/master/libavutil/hwcontext_qsv.c#L316

It is not the only coding style inconsistency around this line. Coding
style inconsistencies cannot be considered precedents.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220720/5daf582c/attachment.sig>


More information about the ffmpeg-devel mailing list