[FFmpeg-devel] [PATCH v2 4/4] avformat/argo_cvg: expose loop/reverb/checksum via metadata

Zane van Iperen zane at zanevaniperen.com
Thu Jul 21 16:38:20 EEST 2022



On 21/7/22 08:00, Andreas Rheinhardt wrote:

>> +    if (av_dict_set_int(&st->metadata, "loop", ctx->header.loop, 0) < 0)
>> +        return AVERROR(ENOMEM);
>> +
>> +    if (av_dict_set_int(&st->metadata, "reverb", ctx->header.reverb, 0) < 0)
>> +        return AVERROR(ENOMEM);
>> +
>> +    if (av_dict_set_int(&st->metadata, "checksum", ctx->checksum, 0) < 0)
>> +        return AVERROR(ENOMEM);
>>
> Don't second-guess error codes (unless you have a good reason to).
> 

Right, don't know why I did that...

I'll apply in a few days (with the fixed return codes).



More information about the ffmpeg-devel mailing list