[FFmpeg-devel] [PATCH] avformat/cafdec: Implement FLAC-in-CAF parsing

Martijn van Beurden mvanb1 at gmail.com
Fri Jun 3 22:47:56 EEST 2022


Op vr 3 jun. 2022 om 19:11 schreef Andreas Rheinhardt
<andreas.rheinhardt at outlook.com>:
>
> You are not checking this; this could lead to uninitialized values being
> used in flac_parse_block_header() below.
>

Yes, indeed, thank you. Interestingly enough, I copied this bit
directly from mov_read_dfla in mov.c, so I'll send a patch for that as
well.

>
> Is there an official spec for this?
>

Not that I know of, but as I was looking at the file the with a hex
editor dfLa stood out as recognizable, as the MP4 spec uses it as well
(as Jan already commented). Therefore I copied most of the code from
mov_read_dfla, with some additions/changes as it is used in a
different context here of course.


More information about the ffmpeg-devel mailing list