[FFmpeg-devel] [PATCH v13 3/4] compat/w32dlfcn.h: Remove MAX_PATH limit and replace LoadLibraryExA with LoadLibraryExW

[Michael Niedermayer]

On Thu, Jun 09, 2022 at 10:04:05PM +0300, Nil Admirari wrote:
> ---
>  compat/w32dlfcn.h | 80 +++++++++++++++++++++++++++++++++++++----------
>  1 file changed, 64 insertions(+), 16 deletions(-)

breaks build on mingw64
CC	libavcodec/mfenc.o
In file included from /usr/share/mingw-w64/include/dshow.h:40:0,
                 from src/libavcodec/mf_utils.h:32,
                 from src/libavcodec/mfenc.c:26:
/usr/share/mingw-w64/include/strmif.h:16503:2: warning: #warning COM interfaces layout in this header has not been verified. [-Wcpp]
 #warning COM interfaces layout in this header has not been verified.
  ^~~~~~~
/usr/share/mingw-w64/include/strmif.h:16504:2: warning: #warning COM interfaces with incorrect layout may not work at all. [-Wcpp]
 #warning COM interfaces with incorrect layout may not work at all.
  ^~~~~~~
/usr/share/mingw-w64/include/strmif.h:16505:1: note: #pragma message: Interface IAMAsyncReaderTimestampScaling has unverified layout.
 __MINGW_BROKEN_INTERFACE(INTERFACE)
 ^~~~~~~~~~~~~~~~~~~~~~~~
/usr/share/mingw-w64/include/strmif.h:16533:2: warning: #warning COM interfaces layout in this header has not been verified. [-Wcpp]
 #warning COM interfaces layout in this header has not been verified.
  ^~~~~~~
/usr/share/mingw-w64/include/strmif.h:16534:2: warning: #warning COM interfaces with incorrect layout may not work at all. [-Wcpp]
 #warning COM interfaces with incorrect layout may not work at all.
  ^~~~~~~
/usr/share/mingw-w64/include/strmif.h:16535:1: note: #pragma message: Interface IAMPluginControl has unverified layout.
 __MINGW_BROKEN_INTERFACE(INTERFACE)
 ^~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/share/mingw-w64/include/dshow.h:33:0,
                 from src/libavcodec/mf_utils.h:32,
                 from src/libavcodec/mfenc.c:26:
src/libavutil/wchar_filename.h: In function ‘add_extended_prefix’:
src/libavutil/wchar_filename.h:211:9: error: ‘wcscpy_instead_use_StringCbCopyW_or_StringCchCopyW’ undeclared (first use in this function)
         wcscpy(temp_w, unc_prefix);
         ^
src/libavutil/wchar_filename.h:211:9: note: each undeclared identifier is reported only once for each function it appears in
In file included from src/compat/w32dlfcn.h:25:0,
                 from src/libavcodec/mfenc.c:32:
src/libavutil/wchar_filename.h:211:22: warning: left-hand operand of comma expression has no effect [-Wunused-value]
         wcscpy(temp_w, unc_prefix);
                      ^
src/libavutil/wchar_filename.h:211:15: warning: statement with no effect [-Wunused-value]
         wcscpy(temp_w, unc_prefix);
               ^
In file included from /usr/share/mingw-w64/include/dshow.h:33:0,
                 from src/libavcodec/mf_utils.h:32,
                 from src/libavcodec/mfenc.c:26:
src/libavutil/wchar_filename.h:212:9: error: ‘wcscat_instead_use_StringCbCatW_or_StringCchCatW’ undeclared (first use in this function); did you mean ‘wcscpy_instead_use_StringCbCopyW_or_StringCchCopyW’?
         wcscat(temp_w, path_w + 2);
         ^
In file included from src/compat/w32dlfcn.h:25:0,
                 from src/libavcodec/mfenc.c:32:
src/libavutil/wchar_filename.h:212:22: warning: left-hand operand of comma expression has no effect [-Wunused-value]
         wcscat(temp_w, path_w + 2);
                      ^
src/libavutil/wchar_filename.h:212:22: warning: statement with no effect [-Wunused-value]
         wcscat(temp_w, path_w + 2);
               ~~~~~~~^~~~~~~~~~~~~
src/libavutil/wchar_filename.h:220:22: warning: left-hand operand of comma expression has no effect [-Wunused-value]
         wcscpy(temp_w, extended_path_prefix);
                      ^
src/libavutil/wchar_filename.h:220:15: warning: statement with no effect [-Wunused-value]
         wcscpy(temp_w, extended_path_prefix);
               ^
src/libavutil/wchar_filename.h:221:22: warning: left-hand operand of comma expression has no effect [-Wunused-value]
         wcscat(temp_w, path_w);
                      ^
src/libavutil/wchar_filename.h:221:15: warning: statement with no effect [-Wunused-value]
         wcscat(temp_w, path_w);
               ^
src/ffbuild/common.mak:81: recipe for target 'libavcodec/mfenc.o' failed
make: *** [libavcodec/mfenc.o] Error 1

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you drop bombs on a foreign country and kill a hundred thousand
innocent people, expect your government to call the consequence
"unprovoked inhuman terrorist attacks" and use it to justify dropping
more bombs and killing more people. The technology changed, the idea is old.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20220610/52a6970c/attachment.sig>